derive standard traits in EcalComponents #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5614a94 to
8332f2f
Compare
- derive Clone so one can duplicate it for another owner - derive PartialEq to test if components differ - derive Debug for printing
8332f2f to
d7bc20e
Compare
There was a problem hiding this comment.
Pull request overview
This PR enhances the EcalComponents bitflags struct by deriving three standard Rust traits to improve usability and ergonomics when working with eCAL component configurations.
- Adds
Clonetrait to enable duplication of components for use across threads - Adds
PartialEqtrait to enable comparison of component configurations - Adds
Debugtrait to enable formatted printing and debugging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Thank you @teresi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added some common traits to make it easier to work with EcalComponents
The main one is Clone so you can send a duplicate to another thread for example (bitflags appears to need clone, not copy)
Related Issues / Discussions
No relevant issues
Checklist
cargo check,cargo test)Screenshots / Output (if applicable)
the debug output looks like this, for DEFAULT in this example