Skip to content

Conversation

@mcserra
Copy link
Contributor

@mcserra mcserra commented Jul 2, 2020

Solves #4348
Signed-off-by: Miguel Serra Miguel.Serra@criticaltechworks.com

@senivam
Copy link
Contributor

senivam commented Jul 3, 2020

Thanks for the PR. First of all I would like you take a look at Check Style notifications (in failed build on travis) and copyright year/headers adjustments. And also I would like to ask @Verdent to take a look at the PR.

Signed-off-by: Miguel Serra <Miguel.Serra@criticaltechworks.com>
@mcserra
Copy link
Contributor Author

mcserra commented Jul 3, 2020

Thanks. @senivam. I made the changes and the build still failed, but the error is not related to my changes, I guess

@senivam
Copy link
Contributor

senivam commented Jul 3, 2020

@mcserra now it's only technical issue, build will pass, thank you for fixes.

Copy link
Member

@Verdent Verdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senivam
Copy link
Contributor

senivam commented Jul 8, 2020

@mcserra please consider accepting PR to your branch 1, after that this PR can be merged

Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
@mcserra
Copy link
Contributor Author

mcserra commented Jul 8, 2020

Done! Thanks

@senivam senivam merged commit a05f5fb into eclipse-ee4j:master Jul 8, 2020
@jansupol jansupol added this to the 2.32 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants