Skip to content

Remove Guava under version 24 #5175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
senivam merged 7 commits into from
Dec 1, 2022
Merged

Remove Guava under version 24 #5175

senivam merged 7 commits into from
Dec 1, 2022

Conversation

@jbescos
Copy link
Member

@jbescos jbescos commented Oct 11, 2022 •
edited
Loading

  • Some dependencies that bring Guava under version 24 have exclusions. Good news is that we only use them for testing/exampling purposes. Lets see if tests are passing with that exclusion.
  • With others like testng, just updating the version brings a correct Guava.
  • Testng new version works with arquilian-testng in alpha version unfortunately. I hope this is not a problem.

@jbescos
Remove Guava under version 24
65734d2 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos jbescos force-pushed the guavaSecurity branch 5 times, most recently from 918cb8a to a7b803e Compare October 12, 2022 07:17
@jbescos
Copy link
Member Author

jbescos commented Oct 12, 2022

The build is failing, but when I check the output the maven part is success:

[INFO] jersey-examples-moxy ............................... SUCCESS [  2.645 s]
[INFO] jersey-test-framework-maven-custom-enforcer-rules .. SUCCESS [  2.041 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  56:01 min
[INFO] Finished at: 2022-10-12T08:14:29Z
[INFO] ------------------------------------------------------------------------
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // stage
[Pipeline] End of Pipeline
ERROR: script returned exit code 1

GitHub has been notified of this commit’s build result

Finished: FAILURE

@jbescos
Fix tests
f4214e3 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@senivam
Copy link
Contributor

senivam commented Oct 12, 2022

@jbescos build fails for JDK 8 only, here is the log:
https://ci.eclipse.org/jersey/job/continuous-integration/job/PR-5175/7/execution/node/34/log/
the reason is:

Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure
/home/jenkins/agent/workspace/continuous-integration_PR-5175/test-framework/core/src/main/java/org/glassfish/jersey/test/JerseyTestNg.java:[27,30] cannot access org.testng.annotations.AfterClass
  bad class file: /home/jenkins/.m2/repository/org/testng/testng/7.6.1/testng-7.6.1.jar(org/testng/annotations/AfterClass.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.

@jansupol
Copy link
Contributor

jansupol commented Oct 12, 2022 •
edited
Loading

Requirements:
TestNG Upto v7.5: JDK 8 or higher.
TestNG v7.6.0 and above: JDK 11 or higher.
..........................................................................................
So we should not go higher than 7.5 in master/3.x

@jbescos jbescos force-pushed the guavaSecurity branch 2 times, most recently from 7a8d538 to 9fc4ef9 Compare October 12, 2022 10:57
@jbescos
Update testng and arquilian version to work with JDK8
cbd0c3d 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Copy link
Member Author

jbescos commented Oct 12, 2022

I have tuned the versions to work fine with JDK8 and we also don't need to use an alpha version of arquilian.

@jbescos
Copy link
Member Author

jbescos commented Oct 12, 2022

These are the guava dependencies that we will have with the fix:

$ mvn dependency:tree | grep 'google\.guava'
[INFO] +- com.google.guava:guava:jar:31.1-jre:compile
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] |  |  \- com.google.guava:guava:jar:25.1-android:compile
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] +- com.google.guava:guava:jar:31.1-jre:compile
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] |  \- com.google.guava:guava:jar:31.1-jre:compile
[INFO] |     +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |     +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile

This is what we have now in master:

$ mvn dependency:tree | grep 'google\.guava'
[INFO] |  |  \- com.google.guava:guava:jar:16.0.1:provided
[INFO] |  \- com.google.guava:guava:jar:16.0.1:compile
[INFO] +- com.google.guava:guava:jar:31.1-jre:compile
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] |     \- com.google.guava:guava:jar:16.0.1:test
[INFO] |     \- com.google.guava:guava:jar:16.0.1:test
[INFO] |     \- com.google.guava:guava:jar:16.0.1:test
[INFO] |     \- com.google.guava:guava:jar:16.0.1:test
[INFO] |  |  \- com.google.guava:guava:jar:16.0.1:test
[INFO] |  +- com.google.guava:guava:jar:20.0:test
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] |  |  \- com.google.guava:guava:jar:16.0.1:test
[INFO] |  |  \- com.google.guava:guava:jar:25.1-android:compile
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] |     +- com.google.guava:guava:jar:16.0.1:compile
[INFO] |  \- com.google.guava:guava:jar:31.1-jre:compile
[INFO] |     +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |     +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile

@jbescos
Merge with master
8557364 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Copy link
Member Author

jbescos commented Nov 16, 2022 •
edited
Loading 

$ mvn dependency:tree | grep 'google\.guava'
[INFO] +- com.google.guava:guava:jar:31.1-jre:compile
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] |  |  \- com.google.guava:guava:jar:25.1-android:provided
[INFO] +- com.google.guava:guava:jar:31.1-jre:test
[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:test
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:test
[INFO] |  \- com.google.guava:guava:jar:31.1-jre:compile
[INFO] |     +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |     +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile

@jbescos
Solving conflicts
302ca6a 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Fix tests
6ac6520 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@senivam senivam merged commit ab8ac91 into eclipse-ee4j:master Dec 1, 2022
@renovate renovate bot mentioned this pull request Jun 15, 2023
Merged
1 task
This was referenced Jul 6, 2023
Open
Open
This was referenced Aug 28, 2023
Merged
Merged
This was referenced Jan 16, 2024
Closed
Closed
@renovate renovate bot mentioned this pull request Mar 1, 2024
Merged
1 task
This was referenced Mar 18, 2024
Merged
Closed
This was referenced Apr 13, 2024
Merged
Closed
Closed
@renovate renovate bot mentioned this pull request Feb 18, 2025
Closed
1 task
This was referenced Feb 23, 2025
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Mar 31, 2025
Open
This was referenced May 26, 2025
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Oct 5, 2025
Merged
1 task
This was referenced Oct 12, 2025
Open
Open
Open
@renovate renovate bot mentioned this pull request Nov 7, 2025
Merged
1 task
@renovate-bot renovate-bot mentioned this pull request Nov 18, 2025
Closed
1 task
This was referenced Nov 18, 2025
Closed
Closed
@renovate-bot renovate-bot mentioned this pull request Nov 19, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansupol jansupol jansupol approved these changes

@senivam senivam senivam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.38

Development

Successfully merging this pull request may close these issues.

3 participants

@jbescos @senivam @jansupol