AArch64: Do not skip l2a node if the MemoryReference has UnresolvedDataSnippet #6454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taSnippet `populateMemoryReference` function skips `l2a` node if the node's reference count is 1 and node does not have a register. Skipping it makes the base register of the memory reference a non-collected reference register. This is incorrect but harmless in normal cases. However, if the memory reference has a UnresolvedDataSnippet, the first generated instruction would be a branch to the snippet. The resolution helper is called fron the snippet, which may trigger GC. Because GC does not know about the base register, the value of the base register would not be updated correctly. This commit changes `populateMemoryReference` to evaluate `l2a` node if the memory reference has a UnresolvedDataSnippet. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Contributor
Author
|
This is the fix for eclipse-openj9/openj9#14663. |
Contributor
|
Jenkins build aarch64 |
knn-k
approved these changes
Apr 1, 2022
Contributor
|
I ran sanity.functional with JDK 17 and 18 on AArch64 Linux, and they were successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populateMemoryReferencefunction skipsl2anode if the node's referencecount is 1 and node does not have a register.
Skipping it makes the base register of the memory reference
a non-collected reference register. This is incorrect but harmless in normal
cases. However, if the memory reference has a UnresolvedDataSnippet,
the first generated instruction would be a branch to the snippet. The resolution
helper is called fron the snippet, which may trigger GC. Because GC does not
know about the base register, the value of the base register would not be
updated correctly.
This commit changes
populateMemoryReferenceto evaluatel2anode ifthe memory reference has a UnresolvedDataSnippet.
Signed-off-by: Akira Saitoh saiaki@jp.ibm.com