Skip to content

Add macOS on AArch64 #6637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0xdaryl merged 1 commit into from
Oct 6, 2022
Merged

Add macOS on AArch64 #6637

0xdaryl merged 1 commit into from
Oct 6, 2022

Conversation

@AdamBrousseau
Copy link
Contributor

@AdamBrousseau AdamBrousseau commented Aug 4, 2022

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Aug 4, 2022

@0xdaryl can you give this a review please? I copied the mac x64 spec and only changed the spec name and machine label.

@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Aug 4, 2022

Jenkins build amac

@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Aug 4, 2022

https://ci.eclipse.org/omr/job/PullRequest-osx_aarch64/5/console

00:08:40.056  59% tests passed, 12 tests failed out of 29
00:08:40.056  
00:08:40.056  Total Test time (real) = 196.17 sec
00:08:40.056  
00:08:40.056  The following tests FAILED:
00:08:40.056  	  3 - conditionals_example_as_test (SEGFAULT)
00:08:40.056  	  5 - iterfib_example_as_test (SEGFAULT)
00:08:40.056  	  6 - nestedloop_example_as_test (SEGFAULT)
00:08:40.056  	  7 - pow2_example_as_test (SEGFAULT)
00:08:40.056  	  8 - simple_example_as_test (SEGFAULT)
00:08:40.056  	  9 - worklist_example_as_test (SEGFAULT)
00:08:40.056  	 14 - porttest (Failed)
00:08:40.056  	 25 - JitBuilderTest (SEGFAULT)
00:08:40.056  	 26 - CompilerTest (SEGFAULT)
00:08:40.056  	 27 - triltest (SEGFAULT)
00:08:40.056  	 28 - comptest (SEGFAULT)
00:08:40.056  	 29 - compunittest (SEGFAULT)
00:08:40.056  Errors while running CTest

@0xdaryl
Copy link
Contributor

0xdaryl commented Sep 22, 2022

See issue #6716 to track failures.

@0xdaryl 0xdaryl mentioned this pull request Oct 4, 2022
Merged
@babsingh
Copy link
Contributor

babsingh commented Oct 4, 2022

Can this be merged? Let's not include it in the build all trigger on Jenkins until segfaults are fixed. But it will help us to compile and selectively run tests as fixes are merged: amac(env:'GTEST_FILTER=<TEST_REGEX>').

@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Oct 4, 2022

I'll wait and rebase once #6724 is merged.

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 5, 2022

Please rebase.

@AdamBrousseau
Add macOS on AArch64
e3d4a15 
Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau marked this pull request as ready for review October 6, 2022 18:01
@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Oct 6, 2022

@0xdaryl for review.

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 6, 2022

Jenkins build amac

Mainly testing the trigger. I expect some of these test jobs will fail.

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 6, 2022

Jenkins build amac

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 6, 2022

@AdamBrousseau : the trigger doesn't seem to be working.

@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Oct 6, 2022

Jenkins build amac

@0xdaryl 0xdaryl self-assigned this Oct 6, 2022
@0xdaryl 0xdaryl merged commit 04c19ff into eclipse-omr:master Oct 6, 2022
@knn-k knn-k mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xdaryl 0xdaryl 0xdaryl approved these changes

@charliegracie charliegracie Awaiting requested review from charliegracie

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees

@0xdaryl 0xdaryl

Labels

build / configure ci documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdamBrousseau @0xdaryl @babsingh