Skip to content

Add execute flag for __moservice allocations on zOS #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
babsingh merged 1 commit into from
Nov 22, 2022
Merged

Add execute flag for __moservice allocations on zOS #6824

babsingh merged 1 commit into from
Nov 22, 2022

Conversation

@joransiu
Copy link
Contributor

@joransiu joransiu commented Nov 21, 2022

A new __MOPL_EXECUTABLE flag is being defined to the zOS LE __moservices() call to specify executable property under PTF UI83032. Explicitly set the execute storage flags for memory allocated with __moservices if appropriate.

@joransiu
Copy link
Contributor Author

joransiu commented Nov 21, 2022

@babsingh : Do you mind reviewing this? Thanks!

babsingh
babsingh requested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description has more details. The commit message does not match the PR description. Also, the commit message's body should be wrapped at 72 characters: https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines.

@joransiu
Copy link
Contributor Author

joransiu commented Nov 22, 2022

Thanks for the quick feedback @babsingh! I should have addressed all your concerns in c7f7958. Thanks!

@babsingh
Copy link
Contributor

babsingh commented Nov 22, 2022

Thanks. Only the following feedback is pending: #6824 (review)

The PR description has more details. The commit message does not match the PR description. Also, the commit message's body should be wrapped at 72 characters: https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines.

@joransiu
Add execute flag for __moservice allocations on zOS
ca89e73 
A new __MOPL_EXECUTABLE flag is being defined to the zOS LE
__moservices() call to specify executable property under PTF
UI83032. Explicitly set the execute storage flags for memory
allocated with __moservices if appropriate.

Signed-off-by: Joran Siu <joransiu@ca.ibm.com>
@joransiu
Copy link
Contributor Author

joransiu commented Nov 22, 2022

Thanks. Only the following feedback is pending: #6824 (review)

The PR description has more details. The commit message does not match the PR description. Also, the commit message's body should be wrapped at 72 characters: https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines.

Sorry, somehow missed that comment. I've updated the commit message text.

@babsingh
Copy link
Contributor

babsingh commented Nov 22, 2022

jenkins build all

@babsingh
Copy link
Contributor

babsingh commented Nov 22, 2022 •
edited
Loading

https://ci.eclipse.org/omr/job/PullRequest-linux_ppc-64_le_gcc/3880/consoleFull

16:07:26  30: �[0;32m[----------] �[m14 tests from Special/PPCDirectEncodingTest
16:07:26  30: free(): invalid next size (normal)
16:07:26  30/30 Test #30: compunittest ......................Child aborted***Exception:   0.89 sec

@babsingh babsingh merged commit dc42afa into eclipse-omr:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@babsingh babsingh babsingh approved these changes

@charliegracie charliegracie Awaiting requested review from charliegracie

@youngar youngar Awaiting requested review from youngar

Assignees

No one assigned

Labels

arch:z comp:port

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joransiu @babsingh