Add new core dump tool for OSX #6014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @manqingl |
|
@klangman @JamesKingdon : FYI |
Contributor
Author
|
On one of the Open9 DDR tests, the utility creates a vastly inflated core file (100GB+) running the following command: Looking into the issue now. |
8fae4d1 to
df293fe
Compare
Contributor
Author
|
Fixed the issue with core file size inflation. This PR is ready for review. |
keithc-ca
suggested changes
May 27, 2021
Contributor
Author
|
Updated the PR, can you take another look please @keithc-ca |
keithc-ca
reviewed
Jun 7, 2021
c8376ec to
e257dad
Compare
Contributor
Author
|
@keithc-ca I've updated the PR, can you take another look please? |
keithc-ca
suggested changes
Jul 7, 2021
e257dad to
2f9ea8d
Compare
Contributor
Author
|
@keithc-ca Updated the PR again. |
keithc-ca
suggested changes
Jul 8, 2021
2f9ea8d to
e7d0cd3
Compare
keithc-ca
approved these changes
Jul 12, 2021
Contributor
keithc-ca
left a comment
There was a problem hiding this comment.
I think this should be squashed: one commit is sufficient for one new file.
Please create an issue to address removal of memory allocations (that will fail in low memory scenarios).
e7d0cd3 to
c88ec5b
Compare
Contributor
Author
|
Squashed commits into one. |
Dumping core using the signal requires an the task-get-allow entitlement, which prevents notarization. Thus we dump the core with a user space tool which does not require an entitlement. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
c88ec5b to
cfed42b
Compare
Contributor
|
Jenkins build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping core using the signal requires an the task-get-allow
entitlement, which prevents notarization. Thus we dump the core
with a user space tool which does not require an entitlement.
Signed-off-by: Mike Zhang mike.h.zhang@ibm.com
Resolves #5813
fyi @keithc-ca