AArch64: Assembly helper for arraycopy #6073
Conversation
|
@0xdaryl Could you review this, please? I am a co-author of this PR. |
| bhi __backwardArrayCopy // byteLength > dstAddr - srcAddr, must do backward array copy | ||
| // Forward copy case: fall through | ||
|
|
||
| __forwardArrayCopy: |
There was a problem hiding this comment.
If this is an external callable entry point, please provide some documentation on the API and what it accomplishes functionally.
There was a problem hiding this comment.
Thanks for the comment, but if this is callable from JITed code please describe the API like you do for _arraycopy. For example (tailor it to what the register usage actually is):
// in: x0 - length in bytes
// x1 - src addr
// x2 - dst addr
// trash: x3, x4
| finished: | ||
| ret | ||
|
|
||
| __backwardArrayCopy: |
There was a problem hiding this comment.
If this is an external callable entry point, please provide some documentation on the API and what it accomplishes functionally.
There was a problem hiding this comment.
Thanks for the comment, but if this is callable from JITed code please describe the API like you do for _arraycopy. For example (tailor it to what the register usage actually is):
// in: x0 - length in bytes
// x1 - src addr
// x2 - dst addr
// trash: x3, x4
| .text | ||
| .align 2 | ||
|
|
||
| // Copy array elements |
There was a problem hiding this comment.
Can you provide a bit more of a description of what this code does? For example, this is a generic entry point that will determine which direction to copy as appropriate, so the description of this functionality should reflect that.
f000310 to
aaed850
Compare
This commit adds assembly file for arraycopy for primitive nodes in forward and backward directions. Issue: eclipse-omr#6438 Co-authored-by: KONNO Kazuhiro <konno@jp.ibm.com> Signed-off-by: Siri Sahithi Ponangi <sahithi.ponangi@unb.ca>
|
Jenkins build aarch64 |
This commit adds assembly file for arraycopy for primitive
nodes in forward and backward directions.
Issue: #6438
Co-authored-by: KONNO Kazuhiro konno@jp.ibm.com
Signed-off-by: Siri Sahithi Ponangi sahithi.ponangi@unb.ca