Invalidate parmInfo for DLT compiles #6079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysun-omr
approved these changes
Jun 21, 2021
| for (TR::TreeTop *tt = comp()->getStartTree(); | ||
| tt; | ||
| tt = tt->getNextTreeTop()) | ||
| if (comp()->isDLT()) |
Contributor
There was a problem hiding this comment.
I would suggest a comment here explaining why DLT compiles are being treated separately.
Should you have a loop that stores 1 into each index in _parmInfo ? I think the memset will store 1 into every byte of the array. I guess I am thinking of a case where some code checks if the _parmInfo int32_t value is precisely 1 and then goes wrong because it is a different non-zero value to the one that it expected.
vijaysun-omr
approved these changes
Jun 22, 2021
Contributor
|
Jenkins build all |
Contributor
|
@0xdaryl would appreciate a review from you too before merging. |
0xdaryl
approved these changes
Jun 22, 2021
Contributor
|
Checks have passed, and reviews are also done. This solves the failure that was reported. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes openj9/#12819