Implement vadd and vsub for Short and ByteVectors of size 128 #6237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: midronij <jackie.midroni@ibm.com>
Contributor
Author
|
@gita-omr @IBMJimmyk could you review when you get a chance please? |
Contributor
|
The changes look good to me. |
gita-omr
approved these changes
Nov 13, 2021
Contributor
|
Jenkins build plinux,aix |
aviansie-ben
suggested changes
Nov 14, 2021
Contributor
aviansie-ben
left a comment
There was a problem hiding this comment.
LGTM from a functional aspect, just one minor style nit.
Signed-off-by: midronij <jackie.midroni@ibm.com>
Contributor
|
Jenkins build plinux,aix |
aviansie-ben
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements vadd and vsub for Short and ByteVectors of size 128