AArch64: Provide factory methods for MemoryReference objects #6279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce static factory methods for MemoryReference objects into aarch64 codegen. Replace all direct calls to MemoryReference constructors with corresponding factory methods. The separate PR will make MemoryReference constructors private. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
This was referenced Dec 22, 2021
Contributor
|
Jenkins build aarch64 |
knn-k
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of a series of PRs to implement #5173.
Introduce static factory methods for MemoryReference objects into aarch64 codegen.
Replace all direct calls to MemoryReference constructors with corresponding factory methods.
The separate PR will make MemoryReference constructors private.
Depends on eclipse-openj9/openj9#14195
Signed-off-by: Akira Saitoh saiaki@jp.ibm.com