Skip to content

Fix problems compiling with gcc 10 #6301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdmpapin merged 1 commit into from
Jan 20, 2022
Merged

Fix problems compiling with gcc 10 #6301

jdmpapin merged 1 commit into from
Jan 20, 2022

Conversation

@keithc-ca
Copy link
Contributor

@keithc-ca keithc-ca commented Jan 13, 2022

Use a flexible array for RegisterDependencyGroup._dependencies, and promote architecture-specific fields so they don't follow that flexible array.

Fixes: eclipse-openj9/openj9#14219.

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 13, 2022 •
edited
Loading

Windows is not cooperating:

D:\a\1\s\compiler/codegen/OMRRegisterDependency.hpp(215): warning C4200: nonstandard extension used: zero-sized array in struct/union [D:\a\1\s\build\fvtest\compilertest\testcompiler.vcxproj]
  D:\a\1\s\compiler/codegen/OMRRegisterDependency.hpp(215): note: This member will be ignored by a defaulted constructor or copy/move assignment operator
  omrportTest.cpp
D:\a\1\s\compiler\x\codegen/OMRRegisterDependency.hpp(65): error C2503: 'OMR::RegisterDependencyGroup': base classes cannot contain zero-sized arrays [D:\a\1\s\build\fvtest\compilertest\testcompiler.vcxproj]
  JBCodeCacheManager.cpp

And it seems the added assertion needs to be relaxed:

5: Test command: /home/vsts/work/1/s/build/jitbuilder/release/iterfib
5: Test timeout computed to be: 10000000
5: Assertion failed at /home/vsts/work/1/s/compiler/codegen/OMRRegisterDependency.hpp:67: numDependencies > 0
5: 	Number of dependencies must be positive

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 13, 2022

Updated to make allowances for MSVC and to relax the new assertion.

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 13, 2022

jenkins build all

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 13, 2022

Apparently, it's only GCC that supports extending a class containing a flexible array member: adjusted accordingly.

Longer term we ought to eliminate extensions to OMR::RegisterDependencyGroup so a flexible array member can be used properly with all compilers.

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 13, 2022

jenkins build all

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 14, 2022

Updated so clang is not treated as gcc.

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 14, 2022

jenkins build all

@AdamBrousseau
Copy link
Contributor

AdamBrousseau commented Jan 14, 2022

Jenkins build xlinux

@keithc-ca keithc-ca mentioned this pull request Jan 17, 2022
Closed
@keithc-ca
Fix problems compiling with gcc 10
e27c697 
Use a flexible array for RegisterDependencyGroup._dependencies
(only for gcc), and promote architecture-specific fields so they don't
follow that array whose size is determined dynamically at runtime.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 17, 2022

jenkins build all

@dsouzai
Copy link
Contributor

dsouzai commented Jan 17, 2022

@jdmpapin do you mind reviewing this one?

@dsouzai
Copy link
Contributor

dsouzai commented Jan 17, 2022

As mentioned in the slack channel, zos build passing depends on #6292

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 18, 2022

jenkins build zos

@keithc-ca
Copy link
Contributor Author

keithc-ca commented Jan 19, 2022

@jdmpapin Do you have any concerns with this?

@jdmpapin jdmpapin merged commit 4dc0bc5 into eclipse-omr:master Jan 20, 2022
@keithc-ca keithc-ca deleted the gcc10 branch January 20, 2022 20:36
@keithc-ca keithc-ca mentioned this pull request Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdmpapin jdmpapin jdmpapin approved these changes

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

@fjeremic fjeremic Awaiting requested review from fjeremic

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees

No one assigned

Labels

arch:x86 arch:z comp:compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiling with gcc 10.3 hangs/crashes with JIT when running -version

4 participants

@keithc-ca @AdamBrousseau @dsouzai @jdmpapin