Relocate Value Propagation analysis of ArrayStoreCHK and arraylength #6323
Conversation
|
Marking this as draft while some tests are running |
963e2ba to
d95d971
Compare
|
Vijay @vijaysun-omr, Annabelle @a7ehuo, may I ask you to review this change? It should be considered in conjunction with OpenJ9 pull request #14411. |
a7ehuo
left a comment
There was a problem hiding this comment.
LGTM. Some minor comments
|
Thanks for reviewing, Annabelle @a7ehuo! It's ready for a re-review. I can squash the most recent commits once all reviews have been completed. |
|
I have approved this after the changes you made. Once Daryl's given his okay for this, one of us can merge it (assuming tests pass). |
Move some analysis of ArrayStoreCHK and arraylength operations out of VPHandlers.cpp so they can be shared with other parts of Value Propagation, particularly in downstream projects. Some OpenJ9-specific code in constrainArrayLength in VPHandlers.cpp will be removed after it is transferred to that downstream project.
73132f8 to
bdfec94
Compare
|
Squashed commits into commit bdfec94 |
|
Jenkins build all |
Daryl @0xdaryl, have you had an opportunity to look at this? |
Move some analysis of
ArrayStoreCHKandarraylengthoperations out of VPHandlers.cpp so they can be shared with other parts of Value Propagation, particularly in downstream projects.Some OpenJ9-specific code in
constrainArrayLengthin VPHandlers.cpp will be removed in a follow up pull request after it is transferred to that downstream project.This is the first planned pull request mentioned in OpenJ9 issue #14402