Remove x87 floating point comparisons #6344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Accumulator register is always NULL for non-x87. Remove as a parameter and fold code from: * generateBranchOrSetOnFPCompare * generateFPCompareResult Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Contributor
Author
|
Jenkins build xlinux,win,osx,x32linux |
Contributor
Author
|
@BradleyWood : please review. |
Contributor
|
LGTM. |
Contributor
Author
|
@dsouzai : would you be able to merge this please? |
dsouzai
reviewed
Feb 11, 2022
dsouzai
reviewed
Feb 11, 2022
Contributor
dsouzai
left a comment
There was a problem hiding this comment.
Looks ok to me; just waiting on the answer to the one review question before approval/merge.
dsouzai
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous initial commits to remove the x87 implementation of floating point comparisons.
Issue #946