CMake: Temporary fix for OMR_CROSSCOMPILING on Windows #6348
Conversation
|
Jenkins build all |
Old method of detecting cygwin->win32 builds was not reliable. As a stop gap measure, assume that any build targeting windows is not a cross compile build. Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
|
@keithc-ca : please approve if you're ok with the changes. |
keithc-ca
left a comment
There was a problem hiding this comment.
I approve, but I'm not sure why this would only be a temporary fix.
Yes, that is a good point. @dnakamura, if there is a better solution planned please let us know. Otherwise, please remove "Temporary fix" from the commit and PR titles and the suggestion that this is a stop gap measure. |
Theoretically you could for example perform a cross-compile on linux targeting windows. The better solution would be to figure out the correct variables etc. to detect if we are on a windows-ish platform (eg mingw/cygwin etc) vs an actual cross compile targeting windows |
|
It's not clear that it will be a priority any time soon to support (real) cross-compiling to Windows. If that were ever to happen, then |
|
I'm going to merge this as-is as I think it is more important to fix a downstream build break then to hold that up while we debate some of the future enhancements here. Devin did outline a potential future enhancement in this PR. |
Old method of detecting cygwin->win32 builds was not reliable. As a stop
gap measure, assume that any build targeting windows is not a cross
compile build.
Signed-off-by: Devin Nakamura devinn@ca.ibm.com