Percent and ratio cleanup in trace points #7511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dmitripivkine please, review |
For resize group of tracepoints in SchedulingDelegate (Balanced GC in OpenJ9), there is a mixup in prints for ratios and factors (values between 0 and 1) and percents (values between 0 and 100). To avoid confusion '%' is added after the percent value or explicitly stated it's a ratio (or factor), accordingly. Signed-off-by: Aleksandar Micic <Aleksandar_Micic@ca.ibm.com>
ab717c7 to
25033d1
Compare
dmitripivkine
approved these changes
Oct 30, 2024
Contributor
dmitripivkine
left a comment
There was a problem hiding this comment.
Looks correct to me.
Contributor
|
jenkins build all |
babsingh
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For resize group of tracepoints in SchedulingDelegate (Balanced GC in OpenJ9), there is a mixup in prints for ratios and factors (values between 0 and 1) and percents (values between 0 and 100).
To avoid confusion '%' is added after the percent value or explicitly stated it's a ratio (or factor), accordingly.