Avoid shifting negative signed value #7521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shifting a negative signed value as was done here produces a clang warning about undefined behaviour. Signed-off-by: Christian Despres <despres@ibm.com>
Contributor
Author
Contributor
|
Hm, that might be a botched merge that I didn't notice as I rebased :( . I think it's also wrong (not just causing a warning). Thanks for catching it. |
Contributor
|
jenkins build all |
Contributor
|
Verified there's no warning message with @cjjdespres 's recovery of the original code. Thanks for this catch @cjjdespres ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shifting a negative signed value as was done here produces a clang warning about undefined behaviour.