Skip to content

Implement mTrueCount on PPC #7770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsouzai merged 3 commits into from
Jun 6, 2025
Merged

Implement mTrueCount on PPC #7770

dsouzai merged 3 commits into from
Jun 6, 2025

Conversation

@midronij
Copy link
Contributor

@midronij midronij commented May 29, 2025

This contribution includes the following changes:

  • Codegen sequence for vectorized mTrueCount for Byte, Short, Int, and LongVector has been implemented for P8+
  • Binary encoder unit tests have been added for newly enabled PPC instructions

@midronij midronij requested review from 0xdaryl and mstoodle as code owners May 29, 2025 20:21
@midronij midronij changed the title WIP: Implement mTrueCount on PPC Implement mTrueCount on PPC Jun 2, 2025
@midronij
Copy link
Contributor Author

midronij commented Jun 2, 2025

@gita-omr @zl-wang could you please review when you have a chance?

@midronij
Enable vpopcntd and vsrd instructions on PPC
a9f6497 
Signed-off-by: midronij <jackie.midroni@ibm.com>
@midronij midronij force-pushed the mTrueCount branch 2 times, most recently from 57bad96 to f0b1ac1 Compare June 4, 2025 15:34
zl-wang
zl-wang suggested changes Jun 5, 2025
View reviewed changes
midronij added 2 commits June 5, 2025 13:23
@midronij
Implement PPC codegen for mTrueCount for Integer types
083dc45 
Signed-off-by: midronij <jackie.midroni@ibm.com>
@midronij
Add binary encoder tests for vpopcntd and vsrd
5cb3779 
Signed-off-by: midronij <jackie.midroni@ibm.com>
zl-wang
zl-wang approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang
Copy link
Contributor

zl-wang commented Jun 5, 2025

@dsouzai please review/approve/merge

dsouzai
dsouzai approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@dsouzai dsouzai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; approving based on Julian's approval.

@dsouzai
Copy link
Contributor

dsouzai commented Jun 5, 2025

jenkins build plinux,aix

@dsouzai dsouzai self-assigned this Jun 5, 2025
@dsouzai
Copy link
Contributor

dsouzai commented Jun 6, 2025

jenkins build aix

@dsouzai
Copy link
Contributor

dsouzai commented Jun 6, 2025

Previous build failed because of

[2025-06-05T20:22:05.305Z] Cannot contact p8-java1-ibm12: java.lang.InterruptedException
Resuming build at Thu Jun 05 16:23:46 EDT 2025 after Jenkins restart
[2025-06-05T20:23:46.657Z] Timeout set to expire in 7 hr 24 min
[2025-06-05T20:23:46.659Z] Waiting for reconnection of p8-java1-ibm12 before proceeding with build
[2025-06-05T20:28:46.662Z] p8-java1-ibm12 has been removed for 5 min 0 sec; assuming it is not coming back, and terminating node step
[2025-06-05T20:28:46.673Z] Timeout set to expire in 1 hr 33 min
[2025-06-05T20:28:46.736Z] Could not connect to p8-java1-ibm12 to send interrupt signal to process

@dsouzai dsouzai merged commit 277b9bd into eclipse-omr:master Jun 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsouzai dsouzai dsouzai approved these changes

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

+1 more reviewer

@zl-wang zl-wang zl-wang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsouzai dsouzai

Labels

arch:power comp:compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@midronij @zl-wang @dsouzai