x86: Support vzeroupper instruction #7788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
jenkins build all |
Contributor
|
Can you explain all the modRM refactoring as part of this PR? Was this needed to support vzeroupper? I'm not saying it's wrong, just unexpected. |
Contributor
Author
The vzeroupper instruction is a VEX instruction that has no operands, and no modRM byte. The refactoring was to handle instructions following this pattern. The failures seem to be quirk of running the binary encoding test on hardware that doesn't support AVX. So by default, it tries to encode the instruction like a legacy SSE instruction. |
Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
Contributor
Author
|
jenkins build all |
0xdaryl
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.