Unconditionally invoke unblock_spinlock_threads #7969
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses a race condition with spinThreads, which may prevent blocked threads from being woken up. Fixes: eclipse-omr#7859 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Contributor
Author
|
jenkins build all |
Contributor
Author
|
The PR build failures are unrelated to the proposed changes; they are known issues. |
Contributor
Author
|
This PR replaces #7968. The SDKs have been generated and provided for perf testing. |
|
How has the perf testing of this gone? |
Contributor
Author
|
@vij-singh Perf testing is ongoing. Microbenchmark results were collected recently and are currently under internal review by @JamesKingdon, @vijaysun-omr and @tajila. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a race condition with
spinThreads, whichmay prevent blocked threads from being woken up.
Fixes: #7859