Fix explanation for enableGuardedCountingRecompilation #7287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsouzai
approved these changes
Mar 21, 2024
Contributor
|
jenkins build all |
dsouzai
reviewed
Mar 21, 2024
dsouzai
requested changes
Mar 21, 2024
Contributor
dsouzai
left a comment
There was a problem hiding this comment.
Gonna risk sounding pendantic, but I suggested some changes to improve the clarity a tad.
Signed-off-by: James You <james.you@protonmail.com>
d986c22 to
770f422
Compare
dsouzai
approved these changes
Mar 21, 2024
Contributor
|
jenkins build all |
Contributor
|
Not really sure about the riscv test failure: but this PR's changes can't impact that. macos failure due to #7181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.