Fix build errors using gcc 13 #7325
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a FILE* handle after a call to fclose() (even for tracing) counts as use-after-free problem. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
gcc 13 believes two entries per bit are required Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
babsingh
approved these changes
Apr 29, 2024
Contributor
babsingh
left a comment
There was a problem hiding this comment.
port library change LGTM
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
May 6, 2024
keithc-ca
added a commit
to keithc-ca/omr
that referenced
this pull request
May 13, 2024
It turns out that eclipse-omr#7325 was ineffective: compilers see straight through that attempt to hide the use-after-close. The trace-point doesn't provide any information that isn't already available by other trace-points at the same level. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
rmnattas
pushed a commit
to rmnattas/omr
that referenced
this pull request
Jun 14, 2024
It turns out that eclipse-omr#7325 was ineffective: compilers see straight through that attempt to hide the use-after-close. The trace-point doesn't provide any information that isn't already available by other trace-points at the same level. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omrfilestream.cOMRSimplifierHandlers.cpp