(0.33) Fix usage of pTOC with portableSCC code run in P10 container #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with the code generated for containers with -XX:+PortableSharedCache option. AOT code generated on P8 uses pTOC and if the same container is used on P10 environment causes a crash as pTOC is not there on P10. The fix will generate materialize sequence of instructions when -XX:+PortableSharedCache option is enabled and not pTOC. Signed-off-by: Bhavani SN <bhavani.sn@ibm.com>
Contributor
Author
pshipton
approved these changes
Jun 1, 2022
ymanton
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the code generated for containers with
-XX:+PortableSharedCache option. AOT code generated on P8 uses
pTOC and if the same container is used on P10 environment causes
a crash as pTOC is not there on P10. The fix will generate
materialize sequence of instructions when -XX:+PortableSharedCache
option is enabled and not pTOC.
Port of eclipse-omr/omr#6523 for the 0.33 release.
Signed-off-by: Bhavani SN bhavani.sn@ibm.com