fix AppImage read-only built-in plugin directory issues #630
Conversation
jfaltermeier
left a comment
There was a problem hiding this comment.
LGTM overall, thanks.
I added one comment inline.
Besides that, during testing I noticed that I no longer get the errors about failed mkdir calls in a readonly directory, which is expected.
However redhat.java still does not seem to work for me:
Activating plugin 'Test Runner for Java' failed: Dependent plugin 'redhat.java' is not installed.
2025-12-15T13:41:35.391Z plugin-host ERROR Promise rejection not handled in one second: EntryNotFound (FileSystemError): Unable to resolve nonexistent file '/home/johannes/.theia-ide/workspace-storage/fc230db0200f850796ea7fca3a00b37a/redhat.java', reason: EntryNotFound (FileSystemError): Unable to resolve nonexistent file '/home/johannes/.theia-ide/workspace-storage/fc230db0200f850796ea7fca3a00b37a/redhat.java'
2025-12-15T13:41:35.391Z plugin-host ERROR With stack trace: EntryNotFound (FileSystemError): Unable to resolve nonexistent file '/home/johannes/.theia-ide/workspace-storage/fc230db0200f850796ea7fca3a00b37a/redhat.java'
at _handleError (/tmp/.mount_TheiaIiRrCU5/resources/app/lib/backend/339.js:1:616945)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
Are you seeing this as well, or is this some local issue on my side?
I can see that the version on my system is a very recent pre release: https://open-vsx.org/extension/redhat/java (1.51.2025121108). Not sure if this could be the reason, but maybe we also need a more stable way to control which versions we get from an extension pack.
|
Thanks for the review @jfaltermeier! |
Copy bundled plugins to a user-writable directory for the built-in plugins since the AppImage mount point is read-only. - Add appimage-helpers.js with plugin copy utilities - Track plugin version metadata to update on version changes - Skip copy on startup if plugins are already up-to-date Fixes GH-627
There was a problem hiding this comment.
Thanks, lgtm.
I redownloaded the plugins and also renamed my old .theia-ide directory, and I do not get the error anymore. So this was probably just local on my machine.
Edit: Going back to the former also brings back the error, so I think it is confirmed that it was on my machine only
What it does
Copy bundled plugins to a user-writable directory for the built-in plugins since the AppImage mount point is read-only.
Fixes GH-627
How to test
Review checklist
Reminder for reviewers