feat: fixed tm to td conversion (#172) #173
Conversation
Signed-off-by: Rohith <rgvmanikanta05@gmail.com>
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thanks @Rohithgvmg for this PR. You need to run the prettier --write src/services/operations.ts in order to the code being formatted according to the prettier rules.
Another thing is the unit tests also need to be changed in operations.test.ts file. You can see them failing when you run yarn test
The comment on line 144 is unnecessary.
There was a problem hiding this comment.
thanks for detailed review, fixed the code , kindly review
Signed-off-by: Rohith <rgvmanikanta05@gmail.com>
3bdbd8d to
1954647
Compare
|
@Rohithgvmg the tests are failing again. Make sure to test locally :) |
|
@Rohithgvmg while the correction to the test is ok (that is the expected behavior), you are not checking for the case with the |
Fixes #172
if @type is an array, only the tm:ThingModel is removed
if string , it is deleted from JSON