Replace Boost.python with Pybind11 ECFLOW-2090#269
Open
marcosbento wants to merge 15 commits into
Open
Conversation
326501c to
2fd6d48
Compare
89c3732 to
0a5e39f
Compare
2ed61fa to
7778372
Compare
332418e to
226ec98
Compare
226ec98 to
2e035c1
Compare
11b8c42 to
ca069b4
Compare
558e90b to
5e203ee
Compare
5e203ee to
430b8b7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #269 +/- ##
===========================================
+ Coverage 49.96% 50.10% +0.14%
===========================================
Files 1238 1240 +2
Lines 98169 98345 +176
Branches 14950 14933 -17
===========================================
+ Hits 49049 49278 +229
+ Misses 49120 49067 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
430b8b7 to
394bba3
Compare
394bba3 to
4cadf1b
Compare
d095a3b to
53839e2
Compare
5cdba0c to
ca62b53
Compare
e13476f to
599ff28
Compare
Increase the test coverage, and thus confidence, for the upcoming change from Boost.python to pybind11. Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
A dict/kwargs key is guaranteed to be string by construction, so it is unnecessary to attempt extraction with error handling. Direct casting the object can be used instead. Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
599ff28 to
bd6dc74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace Boost.python with pybind11
Contributor Declaration
By opening this pull request, I affirm the following: