Skip to content

Enable Node ACL based on ECF_PERMISSIONS ECFLOW-1960 - #309

Draft
marcosbento wants to merge 6 commits into
developfrom
feature/node_acl
Draft

marcosbento wants to merge 6 commits into
developfrom
feature/node_acl

Conversation

@marcosbento

@marcosbento marcosbento commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Enable Node ACL based on ECF_PERMISSION

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-309

@codecov-commenter

codecov-commenter commented Mar 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.33127% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.29%. Comparing base (13d4aab) to head (531c290).

Files with missing lines Patch % Lines
...ibs/server/src/ecflow/server/ServerEnvironment.cpp 51.11% 22 Missing ⚠️
libs/server/src/ecflow/server/HttpServer.cpp 23.80% 16 Missing ⚠️
libs/node/src/ecflow/node/Alias.cpp 40.00% 3 Missing ⚠️
libs/node/src/ecflow/node/formatter/DefsWriter.hpp 88.46% 3 Missing ⚠️
.../server/src/ecflow/server/AuthorisationService.cpp 90.62% 3 Missing ⚠️
libs/node/src/ecflow/node/AuthorisationContext.hpp 81.81% 2 Missing ⚠️
libs/base/src/ecflow/base/cts/user/CSyncCmd.cpp 75.00% 1 Missing ⚠️
libs/base/src/ecflow/base/stc/DefsCache.cpp 85.71% 1 Missing ⚠️
libs/base/src/ecflow/base/stc/SSyncCmd.cpp 94.44% 1 Missing ⚠️
libs/node/src/ecflow/node/Family.cpp 83.33% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
+ Coverage    56.12%   56.29%   +0.17%     
===========================================
  Files         1264     1271       +7     
  Lines       105007   105481     +474     
  Branches     15331    15396      +65     
===========================================
+ Hits         58931    59385     +454     
- Misses       46076    46096      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento
marcosbento force-pushed the feature/node_acl branch 5 times, most recently from fde7c0b to df129dd Compare April 17, 2026 07:35
@marcosbento
marcosbento force-pushed the develop branch 2 times, most recently from e4e5beb to 02a695f Compare April 20, 2026 12:54
@marcosbento
marcosbento force-pushed the feature/node_acl branch 4 times, most recently from 86cd87d to aea1484 Compare April 29, 2026 07:19
@marcosbento
marcosbento force-pushed the feature/node_acl branch 2 times, most recently from 5d06db4 to edcaf92 Compare May 20, 2026 12:35
@marcosbento
marcosbento force-pushed the feature/node_acl branch 3 times, most recently from a6b5981 to ec2b2b2 Compare June 24, 2026 16:24
@marcosbento
marcosbento force-pushed the feature/node_acl branch 6 times, most recently from 30b6e51 to af21159 Compare July 15, 2026 15:14
@marcosbento
marcosbento force-pushed the feature/node_acl branch 4 times, most recently from 99eea7a to 37b5a33 Compare July 21, 2026 09:20
@marcosbento
marcosbento force-pushed the feature/node_acl branch 3 times, most recently from 1d7794c to 50cb54a Compare July 27, 2026 17:06
@marcosbento
marcosbento force-pushed the feature/node_acl branch 3 times, most recently from c2ae0c7 to 0c6ab5e Compare September 2, 2026 07:37
@marcosbento
marcosbento force-pushed the feature/node_acl branch 6 times, most recently from 2c313b3 to d85231c Compare September 8, 2026 05:52
@marcosbento
marcosbento force-pushed the feature/node_acl branch 2 times, most recently from e7f049d to 201a4c7 Compare September 19, 2026 12:27
- LoadDefs: WRITE -> OWNER
- SUSPEND: WRITE -> EXECUTE
- RESUME: WRITE -> EXECUTE
- KILL: WRITE -> EXECUTE
When ECF_PERMISSIONS is defined at server level, the Defs cache is
always updated to ensure the content reflects the current accessible
Defs tree.
Two characterisation tests in TestPermissions.cpp check that a suite
without ECF_PERMISSIONS drops every non-sticky server-level entry, and
that an active set emptied by the restriction step is treated as "no
rules", allowing every user every operation on that subtree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants