feat: extract summary module #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refine system instruction to encourage full-conversation summarization. - Add token management to summary agent to handle long dialogues and avoid context overflows.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the inline summary chain into a dedicated module and adds token-management logic to handle long conversations without overflowing context.
- Removed manual prompt construction in
get_smry_chainand now callcreate_summary_agent - Introduced
api/chatbot/agent/smry.pywith trimming and token-management before summarization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/chatbot/dependencies/agent.py | Replaced inline summary chain with call to create_summary_agent |
| api/chatbot/agent/smry.py | New summary module: prompts, trimming, token management, parsing |
Comments suppressed due to low confidence (3)
api/chatbot/agent/smry.py:1
- [nitpick] The module and filename 'smry.py' is an ambiguous abbreviation; consider renaming it to 'summary.py' (and similarly update references) for better readability.
from typing import Callable
api/chatbot/agent/smry.py:30
- [nitpick] Add a docstring to
create_summary_agentthat explains its parameters (chat_model,token_counter,context_length) and describes the returnedRunnablebehavior.
def create_summary_agent(
api/chatbot/agent/smry.py:30
- There are no unit tests covering the new summary agent logic (token trimming and summary output). Consider adding tests to validate trimming behavior and output parsing under various dialogue lengths.
def create_summary_agent(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Describe what you have changed in this PR.