Tags: eic/EICrecon
Tags
security: restrict workflow permissions to minimum required (#2206) ### Briefly, what does this PR introduce? Set workflow-level permissions to 'contents: read' (minimum) and grant additional permissions only to jobs that need them: - clang-tidy-iwyu: contents: write, pull-requests: write (for creating IWYU fix PRs and posting comments) - llvm-cov: statuses: write (for posting code coverage commit statuses) - trigger-container: statuses: write (for posting GitLab CI status) - deploy-docs: pages: write, id-token: write, pull-requests: write (for deploying GitHub Pages and posting comments) This addresses code scanning security alert about overly permissive workflow permissions by applying the principle of least privilege. Fixes: Various GitHub Code Scanning Alerts, https://github.com/eic/EICrecon/security/code-scanning ### What kind of change does this PR introduce? - [x] Bug fix (issue: permissive securi) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
TOFEndcapSharedHits: reduce sigma until exact value is know (#2170) The current sigma is 1 mm for 100 micron pitch sensor. This may be unlikely. It also causes slowdowns similar to ones we saw in barrel TOF. ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [x] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Yes --------- Co-authored-by: Honey Khindri <ph24r002@smail.iitm.ac.in> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tommy Chun Yuen Tsang <tommytsang3108@hotmail.com.hk>
[Backport v1.30] Add generator status filter to UndoAfterBurner for m… …emory efficiency (#2176) # Description Backport of #2175 to `v1.30`. Co-authored-by: Sakib Rahman <rahmans@myumanitoba.ca> Co-authored-by: Sakib Rahman <srahman1@bnl.gov> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
[Backport v1.30] Add polynomial matrix method rp (#2146) # Description Backport of #2137 to `v1.30`. Co-authored-by: Alex Jentsch <alexmichaeljentsch@gmail.com> Co-authored-by: Alexander Jentsch <ajentsch@bnl.gov> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Updated sensor and light yield constants for EEEMCal digitization (#2131 ) ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Yes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Pulse generation from time-clustered Simcalorimeterhits using a share… …d template (#2004) ### Briefly, what does this PR introduce? This PR is for pulse generation from time-clustered `SimCalorimeterHit`s. To generate a pulse from the contributions that are close in time, a `timeID` is assigned in the `SimCalorimeterHitProcessor`. Since both `SimCalorimeterHit` and `SimTrackerHit` share a common pulse generation mechanism, a shared template algorithm, `PulseGeneration`, has been implemented. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #2001) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
remove mentions of JEventProcessorSequentialRoot, deprecate external … …plugins (#1995) ### Briefly, what does this PR introduce? JEventProcessorSequentialRoot was never used and removed in the latest JANA2 release JeffersonLab/JANA2#456 Let's remove the references to it. Those come from unmaintained documentation and deprecated benchmark, so my proposal is to remove those pieces. **This deprecates support for external plugins**. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No
fix: convert MC2SmearedParticle to algorithms, rename (#1958) ### Briefly, what does this PR introduce? This PR converts MC2SmearedParticle to the algorithms interface and renames it to MC2ReconstructedParticle, fixing #1588. ### What kind of change does this PR introduce? - [x] Bug fix (issue #1588) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
PreviousNext