Add phasespace based forced pid for Far-Backward particles. #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
for more information, see https://pre-commit.ci
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No Clang-Tidy warnings found so I assume my comments were addressed
minjungkim12
pushed a commit
that referenced
this pull request
Jul 19, 2025
### Briefly, what does this PR introduce? Adds an algorithm which recovers the PID of particles detected in certain directions. The Low-Q2 electrons are the only charged particles which can be reconstructed within ~12mrad of the negative z-axis, currently this information isn't included in reconstructed particles. The same approach could to a certain degree be used for the Far-Forward protons. This is a temporary alternative to pursing the larger changes required by #1571 where the reconstructed particles from the tagger would come from a different collection. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Tags Far-Backward reconstructed particles as electrons. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Adds an algorithm which recovers the PID of particles detected in certain directions. The Low-Q2 electrons are the only charged particles which can be reconstructed within ~12mrad of the negative z-axis, currently this information isn't included in reconstructed particles.
The same approach could to a certain degree be used for the Far-Forward protons.
This is a temporary alternative to pursing the larger changes required by #1571 where the reconstructed particles from the tagger would come from a different collection.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Tags Far-Backward reconstructed particles as electrons.