Skip to content

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Jun 4, 2025

Briefly, what does this PR introduce?

This PR cancels the triggered eicweb pipeline when a GitHub workflow later fails or is canceled (for example by a new commit). This reduces the load on eicweb when multiple commits are submitted in relatively quick succession.

Note that canceling the container pipeline on eicweb does not cancel any benchmark pipelines it may have triggered. That's a problem for eicweb to solve, not here (arguably).

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No .

Does this PR change default behavior?

No.

@wdconinc

This comment has been minimized.

@wdconinc
Copy link
Contributor Author

wdconinc commented Jun 8, 2025

@wdconinc wdconinc marked this pull request as ready for review June 8, 2025 00:10
veprbl
veprbl previously approved these changes Jun 8, 2025
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings about applying my suggestion. If this works, this is good.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way is fine too.

@wdconinc wdconinc enabled auto-merge June 8, 2025 20:17
@wdconinc wdconinc added this pull request to the merge queue Jun 8, 2025
Merged via the queue into main with commit 5954c13 Jun 8, 2025
107 of 108 checks passed
@wdconinc wdconinc deleted the ci-cancel-eicweb branch June 8, 2025 20:46
wdconinc added a commit to eic/epic that referenced this pull request Jul 11, 2025
### Briefly, what does this PR introduce?
This PR applies eic/EICrecon#1901 to this repo.
When the github actions fail here, they will also cancel the triggered
container build.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: too many pipelines on eicweb)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants