-
Notifications
You must be signed in to change notification settings - Fork 34
fix(ci): cancel eicweb pipeline if workflow canceled or failed #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
Triggered and canceled at https://eicweb.phy.anl.gov/containers/eic_container/-/pipelines/120790 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong feelings about applying my suggestion. If this works, this is good.
veprbl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way is fine too.
### Briefly, what does this PR introduce? This PR applies eic/EICrecon#1901 to this repo. When the github actions fail here, they will also cancel the triggered container build. ### What kind of change does this PR introduce? - [x] Bug fix (issue: too many pipelines on eicweb) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Briefly, what does this PR introduce?
This PR cancels the triggered eicweb pipeline when a GitHub workflow later fails or is canceled (for example by a new commit). This reduces the load on eicweb when multiple commits are submitted in relatively quick succession.
Note that canceling the container pipeline on eicweb does not cancel any benchmark pipelines it may have triggered. That's a problem for eicweb to solve, not here (arguably).
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No .
Does this PR change default behavior?
No.