fix: avoid duplicate factory name (CentralTrackVertices) #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
I see now that I could have resolved this differently too. Anyway, naming up for debate and improving consistency. In any case, the outputs are still identical:
|
veprbl
approved these changes
Jul 2, 2025
veprbl
reviewed
Jul 2, 2025
minjungkim12
pushed a commit
that referenced
this pull request
Jul 14, 2025
### Briefly, what does this PR introduce? This PR fixes an issue that snuck in with #1744, namely a duplicate factory name `CentralTrackVertices` which results in the warning: ``` 14:47:13.866 [warn] Parameter 'tracking:CentralTrackVertices:InputTags' has conflicting defaults: 'CentralAndB0TrackerCKFActsTrajectories,ReconstructedChargedParticles' vs 'CentralCKFActsTrajectories,ReconstructedChargedParticles' 14:47:13.866 [warn] Parameter 'tracking:CentralTrackVertices:OutputTags' has conflicting defaults: 'CentralAndB0TrackerVertices' vs 'CentralTrackVertices' ``` We'll have to see how this affects the comment at #1744 (comment) ... ### What kind of change does this PR introduce? - [x] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR fixes an issue that snuck in with #1744, namely a duplicate factory name
CentralTrackVerticeswhich results in the warning:We'll have to see how this affects the comment at #1744 (comment) ...
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.