fix: use Navigator with MaterialInteractor action for track propagation #1977
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
This also seems to break my propagation to the dirc reference surface |
If you can, try without the end of world aborter. I'm wondering if that's it. |
|
Yup, removing the end of world aborter restored the propagation. Good suggestion. I also did a quick check ~ 10 events to see what happens to the cov errors when I include and exclude the BOT hits in the tracking. The cov errors now seem consistent in size to what I see with the residues. Previously removing the BOT hits led to cov errors about 2 times smaller. |
|
I'll remove the end of world aborter here, but we should add a proper end of world definition that lives outside of the relevant target surfaces. |
|
Without aborter the calorimeter projections look reasonable. |
|
Shall we merge this to fix the pull distribution, and work on the end of world option with a separate PR? |
4517bee to
193f5a5
Compare
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
for more information, see https://pre-commit.ci
98510d5 to
63be2f7
Compare
veprbl
left a comment
There was a problem hiding this comment.
Approving based on previous approval by Shujie. Diff LGTM
Briefly, what does this PR introduce?
This PR adds an explicit Navigator with MaterialInteractor action for track propagation. This may impact how the material map is taken into account during propagation.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.