fix: improve sitemap-index-stream robustness and test coverage #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add race condition protection with isCreatingSitemap flag - Add comprehensive input validation for URLs and dates - Improve error handling with proper event listener cleanup - Add validation for getSitemapStream callback return values - Enhance documentation with JSDoc and inline comments - Add 16 new test cases covering all validation scenarios - Increase sitemap-index-stream.ts coverage from 73% to 91% - Bring overall project coverage above all thresholds (90%+ statements, 81%+ branches) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the robustness of
sitemap-index-stream.tswith improved error handling, input validation, and race condition protection, along with comprehensive test coverage.Changes
Code Improvements (
lib/sitemap-index-stream.ts)isCreatingSitemapflag to prevent concurrent sitemap creationSitemapIndexStreamwith properErrorLevelhandlinggetSitemapStreamreturn valuesTest Coverage (
tests/sitemap-index.test.ts)Coverage Impact
Test Results
Backward Compatibility
All changes are fully backward compatible. New validations only catch previously uncaught errors, and existing valid code continues to work identically.
🤖 Generated with Claude Code