fix: improve sitemap-item-stream robustness and type safety #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses several bugs and code quality issues in sitemap-item-stream.ts: **Critical Bugs Fixed:** - Add null safety check for video.tag iteration to prevent runtime crash - Fix view_count type handling by using String() instead of .toString() **Code Quality Improvements:** - Make attribute handling consistent by using attrBuilder for gallery_loc - Fix attrBuilder return type from Record<string, string> to StringObj - Add comprehensive JSDoc documentation to attrBuilder function **Test Coverage:** - Add tests for null/undefined video.tag edge cases - Add tests for empty video.tag arrays - Add tests for numeric field serialization (view_count, rating, duration) - Add tests for priority precision handling (full vs fixed) All tests pass (177/177) with 99.1% coverage on sitemap-item-stream.ts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several bugs and code quality issues discovered during an audit of
sitemap-item-stream.ts:Critical Bugs Fixed
video.tagis null/undefined (previously would throwTypeError: Cannot read property Symbol(Symbol.iterator) of null).toString()toString()for more robust type coercion that handles both number and string inputsCode Quality Improvements
gallery_locto useattrBuilder()like all other video attributes, maintaining consistent pattern throughout the codebaseattrBuilderreturn type fromRecord<string, string>toStringObjto accurately reflect that function can return non-string valuesattrBuilderfunction with params, returns, throws, and example for improved maintainabilityTest Coverage
Added 5 new test cases covering:
Test Results
✅ All 177 tests pass
✅ TypeScript compilation successful (ESM + CJS)
✅ Linting passes with no errors
✅ Coverage increased for sitemap-item-stream.ts to 99.1%
Files Changed
lib/sitemap-item-stream.ts- Bug fixes and improvementstests/sitemap-item-stream.test.ts- New edge case tests🤖 Generated with Claude Code