Ability to pass in an ISO "lastmod" string directly #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekalinin
added a commit
that referenced
this pull request
Jun 2, 2014
Ability to pass in an ISO "lastmod" string directly
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream: NodeBB/NodeBB#1578
Would like to pass in a parsed ISO string into the library, instead of having the library do it for me, so I added a new property,
lastmodISO(I'd preferlastmodmyself, but in the interest of backwards compatibility, I called itlastmodISOinstead)Since I store my values in my db as unix timestamp in ms, it seems roundabout to:
So I'd like to just pass it in directly.