Skip to content

add cmake check for fp related options#1300

Merged
pca006132 merged 2 commits into
masterfrom
cmake-check
Jul 15, 2025
Merged

add cmake check for fp related options#1300
pca006132 merged 2 commits into
masterfrom
cmake-check

Conversation

@pca006132

@pca006132 pca006132 commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@pca006132 pca006132 mentioned this pull request Jul 15, 2025
Merged
@pca006132

pca006132 commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator Author

https://github.com/elalish/manifold/actions/runs/16288918757

@codecov

codecov Bot commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (c18032c) to head (8533ae2).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files          32       32           
  Lines        5980     5980           
=======================================
  Hits         5511     5511           
  Misses        469      469

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pca006132

pca006132 commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator Author

It seems that we have some path issues when patching pyi file:

manifold3d.vcxproj -> C:\Users\runneradmin\AppData\Local\Temp\tmp06vfnhzd\build\bindings\python\Release\manifold3d.cp311-win_amd64.pyd
    Generating manifold3d.pyi
    Building Custom Rule D:/a/manifold/manifold/bindings/python/CMakeLists.txt
    Traceback (most recent call last):
      File "D:\a\manifold\manifold\bindings\python\stub_postbuild.py", line 3, in <module>
        with open(sys.argv[1], 'r') as f:
             ^^^^^^^^^^^^^^^^^^^^^^
    FileNotFoundError: [Errno 2] No such file or directory: 'C:/Users/runneradmin/AppData/Local/Temp/tmp06vfnhzd/build/bindings/python/Release/manifold3d.pyi'

Probably need some time to figure that out...

@pca006132

pca006132 commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator Author

@Trzeth any idea?

@Trzeth

Trzeth commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Looking into it.

@Trzeth Trzeth mentioned this pull request Jul 15, 2025
Merged
@pca006132

pca006132 commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator Author

https://github.com/elalish/manifold/actions/runs/16295620358

@pca006132 pca006132 merged commit 73f3afd into master Jul 15, 2025
36 checks passed
@pca006132 pca006132 deleted the cmake-check branch July 15, 2025 14:50
@Trzeth Trzeth mentioned this pull request Jul 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elalish elalish elalish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pca006132 @Trzeth @elalish