Skip to content

fix csg tree bug#1383

Merged
pca006132 merged 2 commits into
masterfrom
fix-csgtree
Oct 14, 2025
Merged

fix csg tree bug#1383
pca006132 merged 2 commits into
masterfrom
fix-csgtree

Conversation

@pca006132

Copy link
Copy Markdown
Collaborator

Closes #1378

Need to check the cache before computing, as we may have already computed the result and removed the set of children.

@codecov

codecov Bot commented Oct 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.99%. Comparing base (34da5f0) to head (4fb8bf6).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/csg_tree.cpp 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1383   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          32       32           
  Lines        6006     6007    +1     
=======================================
+ Hits         5525     5526    +1     
  Misses        481      481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pca006132 pca006132 merged commit 54d0a2e into master Oct 14, 2025
36 checks passed
@pca006132 pca006132 deleted the fix-csgtree branch October 14, 2025 03:13
@pca006132 pca006132 mentioned this pull request Oct 24, 2025
8 tasks
@elalish elalish mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python binding manifold3d.Manifold.to_mesh() causes segmentation fault

1 participant