Skip to content

Loading types should not create new scripts.#1420

Merged
elalish merged 1 commit into
elalish:masterfrom
tonious:no_news_is_good_news
Nov 13, 2025
Merged

Loading types should not create new scripts.#1420
elalish merged 1 commit into
elalish:masterfrom
tonious:no_news_is_good_news

Conversation

@tonious

@tonious tonious commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

monaco-editor-auto-typings triggers editor.onDidChangeModelContent(). When loading the Voronoi example, that would appear as an edit, creating a new script.

@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (75390fe) to head (34f56fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files          32       32           
  Lines        5787     5787           
=======================================
  Hits         5340     5340           
  Misses        447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elalish elalish left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit 84f9a8c into elalish:master Nov 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants