Skip to content

Properly integrate manifold_test into ctest#1520

Merged
elalish merged 3 commits into
elalish:masterfrom
coryrc:fixCtestGtest
Feb 6, 2026
Merged

Properly integrate manifold_test into ctest#1520
elalish merged 3 commits into
elalish:masterfrom
coryrc:fixCtestGtest

Conversation

@coryrc

@coryrc coryrc commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Now each test is a separate entry when running ctest

except Windows. What a PITA.

@codecov

codecov Bot commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.41%. Comparing base (fa6be64) to head (69d9926).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1520   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files          35       35           
  Lines        6024     6024           
=======================================
  Hits         5567     5567           
  Misses        457      457

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coryrc

coryrc commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

Of course it's going to be Windows

manifold_test.vcxproj -> D:\a\manifold\manifold\build\bin\Release\manifold_test.exe
  CMake Error at C:/hostedtoolcache/windows/cmake/4.0.2/x64/cmake-4.0.2-windows-x86_64/share/cmake-4.0/Modules/GoogleTestAddTests.cmake:132 (message):
    Error running test executable.
  
      Path: 'D:/a/manifold/manifold/build/bin/Release/manifold_test.exe'
      Working directory: 'D:/a/manifold/manifold/build/test'
      Result: Exit code 0xc0000135

      Output:
        
  
  Call Stack (most recent call first):
    C:/hostedtoolcache/windows/cmake/4.0.2/x64/cmake-4.0.2-windows-x86_64/share/cmake-4.0/Modules/GoogleTestAddTests.cmake:275 (gtest_discover_tests_impl)

@coryrc

coryrc commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, it's not saying what dll it can't find, must be the deps? Ugh.

elalish
elalish approved these changes Feb 6, 2026
View reviewed changes

@elalish elalish left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit 497cfb5 into elalish:master Feb 6, 2026
36 checks passed
@pca006132 pca006132 mentioned this pull request Feb 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elalish elalish elalish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coryrc @elalish