Fix js bindings for manifold.simplify() with default parameters #1543
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1543 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 35 35
Lines 6094 6094
=======================================
Hits 5633 5633
Misses 461 461 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pca006132
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Manifold.simplify()with no arguments will throw the binding error about invalid number of arguments.Guess embind still doesn't have good way to catch/deal with default arguments. Wasn't sure what to put for the test other than call it and it doesn't throw so I just followed the existing ones.