Skip to content

Commit 882a69a

Browse files
marclopmarclop
authored
release: Fix git config and changelog format (#287)
Fixes the Changelog notes to have the version in the first line as it's the title that GitHub will use for the release. Additionally, fixes the issue where the git config doesn't have any user set, now the script configures it when the settings are missing. Last, corrects the GITHUB_USER to elasticcloudmachine when updating the home-brew tap. Signed-off-by: Marc Lopez <marc5.12@outlook.com>
1 parent c64d740 commit 882a69a

4 files changed

Lines changed: 10 additions & 1 deletion

File tree

‎.github/workflows/release.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,6 @@ jobs:
6262
VERSION: ${{ steps.get_version.outputs.VERSION }}
6363
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
6464
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
65+
GIT_COMMITTER_EMAIL: cloud-delivery@elastic.co
66+
GIT_AUTHOR_EMAIL: cloud-delivery@elastic.co
67+
GIT_AUTHOR_NAME: elasticcloudmachine

‎notes/v1.0.0-beta3.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
v1.0.0-beta3
2+
13
# Changelog
24

35
Download the release binaries:

‎scripts/changelog.tpl.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
vVERSION_REPLACE
2+
13
# Changelog
24

35
Download the release binaries:

‎scripts/update-brew-tap.sh‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ VERSION=$(echo ${1}| sed 's/^v//')
77

88
# Globals
99
FORMULA_FILE=/tmp/homebrew-tap/Formula/ecctl.rb
10-
GITHUB_USER=marclop
10+
if [[ -z ${GITHUB_USER} ]]; then
11+
export GITHUB_USER=elasticcloudmachine
12+
fi
1113

1214
# Execution
1315

0 commit comments

Comments
 (0)