Skip to content

[CI] EsqlActionBreakerIT class failing #114194

Closed
#114303
Closed
[CI] EsqlActionBreakerIT class failing#114194
#114303
Assignees
ivancea
Labels
:Analytics/ES|QLAKA ESQL>test-failureTriaged test failures from CITeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)medium-riskAn open issue or test failure that is a medium risk to future releases

Description

@elasticsearchmachine
elasticsearchmachine
opened on Oct 6, 2024

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:esql:internalClusterTest" --tests "org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT.testRowStatsProjectGroupByDouble" -Dtests.seed=390913EDBDC5313D -Dtests.locale=szl-Latn-PL -Dtests.timezone=Asia/Famagusta -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: Request breaker not reset to 0 on node: node_s2
Expected: <0L>
     but: was <96L>

Issue Reasons:

  • [main] 4 failures in class org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT (0.6% fail rate in 713 executions)
  • [main] 2 failures in step part-3 (0.8% fail rate in 247 executions)
  • [main] 2 failures in pipeline elasticsearch-periodic-platform-support (14.3% fail rate in 14 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (0.8% fail rate in 251 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

Activity

  1. elasticsearchmachine
    added
    :Analytics/ES|QLAKA ESQL
    >test-failureTriaged test failures from CI
    on Oct 6, 2024
  2. elasticsearchmachine
    added a commit that references this issue on Oct 6, 2024

    Mute org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT org.elas…

    8b09e91

  3. elasticsearchmachine commented on Oct 6, 2024

    @elasticsearchmachine
    elasticsearchmachine
    on Oct 6, 2024
    CollaboratorAuthor

    This has been muted on branch main

    Mute Reasons:

    • [main] 4 failures in class org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT (0.6% fail rate in 713 executions)
    • [main] 2 failures in step part-3 (0.8% fail rate in 247 executions)
    • [main] 2 failures in pipeline elasticsearch-periodic-platform-support (14.3% fail rate in 14 executions)
    • [main] 2 failures in pipeline elasticsearch-pull-request (0.8% fail rate in 251 executions)

    Build Scans:

  4. elasticsearchmachine
    added
    Team:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)
    needs:riskRequires assignment of a risk label (low, medium, blocker)
    on Oct 6, 2024

  5. elasticsearchmachine commented on Oct 6, 2024

    @elasticsearchmachine
    elasticsearchmachine
    on Oct 6, 2024
    CollaboratorAuthor

    Pinging @elastic/es-analytical-engine (Team:Analytics)

  6. ivancea
    self-assigned this
    on Oct 7, 2024
  7. ivancea
    added
    medium-riskAn open issue or test failure that is a medium risk to future releases
    and removed
    needs:riskRequires assignment of a risk label (low, medium, blocker)
    on Oct 7, 2024

  8. ivancea commented on Oct 7, 2024

    @ivancea
    ivancea
    on Oct 7, 2024
    Contributor

    Update:

    I can't reproduce it. Some things I tried:

    • Testing in the failing commit with and without the given seeds
    • Testing in main with and without the given seeds
    • In case it was related to these last TDigest/CB PRs (Add CircuitBreaker to TDigest, Step 4: Take into account shallow classes size #113613), I tried to run the testGroupingMultiValueByOrdinals test (The only one using TDigest, via the Percentile function) with an adapted version of EsqlActionBreakerIT#runWithBreaking with the complete range of CB limits (From 256 to 2048), with no result

    Added the medium-risk tag as it disabled the full suite, and given many tests are failing within it, I don't think I can safely limit the muted methods

  9. matthewabbott
    added a commit that references this issue on Oct 10, 2024

    Mute org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT org.elas…

    4abddad
  10. ivancea
    closed this as completedin #114303on Oct 11, 2024
  11. ivancea
    closed this as completedin 5fcfa48on Oct 11, 2024
  12. ivancea
    added a commit that references this issue on Oct 11, 2024

    Fix TDigestState.read CB leaks (elastic#114303)

    5fcfa48
  13. davidkyle
    added a commit that references this issue on Oct 13, 2024

    Fix TDigestState.read CB leaks (elastic#114303)

    2cfccb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

:Analytics/ES|QLAKA ESQL>test-failureTriaged test failures from CITeam:AnalyticsMeta label for analytical engine team (ESQL/Aggs/Geo)medium-riskAn open issue or test failure that is a medium risk to future releases

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions