Skip to content

Remove unused devDependencies - Part 2#9660

Draft
tkajtoch wants to merge 6 commits into
elastic:mainfrom
tkajtoch:build/dependencies-cleanup-2
Draft

Remove unused devDependencies - Part 2#9660
tkajtoch wants to merge 6 commits into
elastic:mainfrom
tkajtoch:build/dependencies-cleanup-2

Conversation

@tkajtoch
Copy link
Copy Markdown
Member

Summary

Following up on the effort I started in #9621, this PR removes more of the unused devDependencies from packages/eui/package.json:

  • @elastic/charts - used on the old docs website to render charts examples
  • @types/cheerio - it was added by me during React 18 upgrade (Add support for React 18 #7012) to resolve Enzyme type errors. It's not needed anymore
  • react-router-dom - used by the old docs website
  • cache-loader, raw-loader, style-loader, cache-loader, file-loader, postcss-loader, sass-loader - used by the old docs website
  • circular-dependency-plugin, fork-ts-checker-webpack-plugin, html-webpack-plugin, terser-webpack-plugin, uglifyjs-webpack-plugin - used by the old docs website
  • get-port, html-format - used by the old docs website

API Changes

N/A

Screenshots

N/A

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 None

Release Readiness

  • Documentation: {link to docs page(s)}
  • Figma: {link to Figma or issue}
  • Migration guide: {steps or link, for breaking/visual changes or deprecations}
  • Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}

QA instructions for reviewer

  • Confirm that the documentation website builds properly
  • Confirm that CI is passing
  • Confirm that the removed devDependencies are not used anywhere in EUI

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

@tkajtoch tkajtoch self-assigned this May 14, 2026
@tkajtoch tkajtoch added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label May 14, 2026
if (prop.name.includes(whiteListedProps)) {
return true;
}
if (prop.parent.fileName.includes('@elastic/charts')) return true;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file can be removed. To keep changes scoped, I decided to just remove this reference in this PR

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @tkajtoch

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @tkajtoch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants