Repository navigation
Click on ML icon while already in ML navigates to empty page #60644
Description
Activity
Pinging @elastic/ml-ui (:ml)
Clicking the ML sidebar icon while inside ML causes the trigging of
onAppLeavebut it doesn't actually leave the ML app.
We have clean up code inonAppLeavewhich is run and so the ML app is left in a broken state.
This is the behaviour that is being seen in this issue. Converting toBrowserRouterdoesn't fix it.I've been informed that using
onAppLeavefor plugin clean up is not correct. So please ignore the previous comment.
This issue can be easily resolved by moving our clean up code out ofonAppLeave
Kibana version: master
Browser version: Chrome 80
Browser OS version: macOS Catalina
Description of the problem including expected versus actual behavior:
In certain cases you can get into a broken state with ML's frontend routing
Steps to reproduce:
Errors in browser console (if relevant): No errors
This may be related to #53692 which a fix was made available in #56705.
I see that ML is still using a HashRouter. It is recommended to switch to the regular BrowserRouter and set up redirects when a hash is detected on the root route. That may help solve the problem.