Skip to content

Dependency version bug with plugins #6236

Closed
Closed
Dependency version bug with plugins#6236
Labels
Feature:PluginsTeam:CorePlatform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//

Description

@kimjoar
kimjoar
opened on Feb 12, 2016

I have this dep in my plugin "semver": "^5.1.0", but when running the app I get the semver specified in Kibana's package.json, namely "semver": "4.3.6". Because of a bug in semver my plugins fails.

I find this comment in the bundle built by Kibana:

// Use the define() function if we're in AMD land

which exists in 4.3.6, but not in 5.1.0.

We need to find a way to make sure plugins get the right versions of dependencies, otherwise I think we'll see lots of strange, subtle bugs.

Activity

  1. rashidkpc
    added
    discuss
    on Feb 14, 2016
  2. tylersmalley
    added
    Feature:Plugins
    Team:CorePlatform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//
    and removed
    discuss
    on Jan 9, 2017

  3. tylersmalley commented on Jan 9, 2017

    @tylersmalley
    tylersmalley
    on Jan 9, 2017
    Member

    Any thoughts on this @spalger? Is this something you think we can fix or will it need to be apart of the re-architecture? #7322 will also resolve it once plugins are compiled outside Kibana.

  4. spalger commented on Jan 16, 2017

    @spalger
    spalger
    on Jan 16, 2017
    Contributor

    I doubt this is still an issue, and if it is it shouldn't be... Maybe we were still using webpack's DedupePlugin at the time this was filed...

  5. kimjoar commented on Jan 17, 2017

    @kimjoar
    kimjoar
    on Jan 17, 2017
    ContributorAuthor

    Yeah, I think the dedupe stuff was the problem back then. I'll close this issue, let's just re-open if anyone else experiences something similar

  6. kimjoar
    closed this as completedon Jan 17, 2017
  7. jbudz
    added a commit that references this issue on Nov 18, 2022

    Upgrade EUI to v70.2.4 (#144845)

    c408ceb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature:PluginsTeam:CorePlatform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t//

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions