Skip to content

Timepicker step forward/backward buttons should not result in ranges that overlap #11061

Description

@lukasolson

Currently, when you use the step forward/backward buttons in the timepicker, the ranges will overlap.

For example, say I have "Today" selected as the date range, which results in the following time range:

2017-04-05 00:00:00.000 to 2017-04-05 23:59:59.999

If I step backward, the new time range will be

2017-04-04 00:00:00.001 to 2017-04-05 00:00:00.000

Since the time range is inclusive, any entries that are at exactly 2017-04-05 00:00:00.000 will show up in both time ranges. This is counter-intuitive. If I step backward/forward in time, I wouldn't expect to see the exact same documents.

I think the fix would be simply to move both the "from" and "to" backward by 1 millisecond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Feature:TimepickerTimepickerPR sentbugFixes for quality problems that affect the customer experiencegood first issuelow hanging fruit

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions