Repository navigation
[Fleet] Rework "Dry Run" package policy upgrade logic into its own endpoint #115570
Description
Activity
Pinging @elastic/fleet (Team:Fleet)
The upgrade endpoint has actually this format:
POST /package_policies/upgrade { packagePolicyIds: [...], dryRun: false }After a discussion with @kpollich we determined that a better solution would be to split it in two
POSTendpoints, similar to what we already have:POST /package_policies/upgrade { packagePolicyIds: [...] } POST /package_policies/upgrade/dry_run { packagePolicyIds: [...] }This way we can keep passing an array of ids through the body, which is necessary as we run a "bulk" dry run in the "automatic package policy upgrade" modal on the integration settings page.
Reacted by Jen Huang
Context: #114914 (comment)
We should make a clear distinction between the mutative
upgradeoperation and the read-onlydry runoperation for package policy upgrades by supporting two different HTTP verbs for these API calls.The existing
POST /package-policy/<id>/upgradeendpoint should remain the same, and will serve the purpose of upgrading a package policy to the latest installed version of its package. It does not support edits to the policy.We should create a new
GET /package-policy/<id>/upgradeendpoint that fulfills the same contract as the existing workflow around the request: