Skip to content

Map orphans sources on layer deletion #158133

Description

@desean1625

Describe the bug:
When a layer is removed via the toc_entry_actions_popover or a layer preview is canceled the layer is cleaned up correctly but the source isn't ever removed leading to orphaned sources.

Not a huge issue because I am able to work around it. 99.9% of developers would never encounter this.

But it forces me to reach into maplibre and utilize a private property to determine if the layer has been removed but the source is still present.

Steps to reproduce:

  1. create a layer
  2. cancel the layer
  3. check mbmap.getSource(sourceid) and the source is still there.

Expected behavior:
source to be removed when layer is removed.

Activity

  1. added
    bugFixes for quality problems that affect the customer experience
    on May 19, 2023
  2. elasticmachine commented on May 29, 2023

    @elasticmachine
    Contributor

    Pinging @elastic/kibana-presentation (Team:Presentation)

  3. self-assigned this
    on Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Feature:MapsTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//bugFixes for quality problems that affect the customer experienceregression

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions