Skip to content

Visualization query errors hidden #29900

Description

@spalger

Kibana version: master
Elasticsearch version: master
Original install method (e.g. download page, yum, from source, etc.): source

Describe the bug:

When an invalid query is typed into the filter bar, or a filter aggregation, and sent to Elasticsearch. The error that comes back from elasticsearch is not shown to the user and the app just looks unresponsive.

Steps to reproduce:

  1. Create a new visualization
  2. In a filter aggregation use the filter :"FOO"
  3. Update the visualization

Expected behavior:

The error should be shown to the user so they can fix their query

Errors in browser console (if relevant):
image

Activity

  1. added
    Feature:VisualizationsGeneric visualization features (in case no more specific feature label is available)
    Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//
    on Feb 2, 2019
  2. elasticmachine commented on Feb 2, 2019

    @elasticmachine
    Contributor

    Pinging @elastic/kibana-app

  3. timroes commented on Feb 4, 2019

    @timroes
    Contributor

    cc @lukeelmers @ppisljar could you check if that's gone once the infrastructure is reverted

  4. ppisljar commented on Feb 5, 2019

    @ppisljar
    Contributor

    not happening after revert

  5. ppisljar commented on Feb 5, 2019

    @ppisljar
    Contributor

    pipeline_data_loader catches the errors, but doesn't show the toast (the way visualize_data_loader does).
    code for error handling should be extracted and used in both.

  6. added
    bugFixes for quality problems that affect the customer experience
    Feature:ExpressionLanguageInterpreter expression language (aka canvas pipeline)
    and removed on Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Feature:ExpressionLanguageInterpreter expression language (aka canvas pipeline)Feature:VisualizationsGeneric visualization features (in case no more specific feature label is available)Team:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//bugFixes for quality problems that affect the customer experiencev7.0.0

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions